Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the BOM from the only file I have found it on. #206

Merged
merged 1 commit into from
Jun 27, 2014

Conversation

Martii
Copy link
Member

@Martii Martii commented Jun 26, 2014

If running Linux a good recursive method for detecting these is:

$ find . -type f -print0 | xargs -0r awk '/^\xEF\xBB\xBF/ {print FILENAME} {nextfile}'

Applies to #200 and #198


Byte Order Mark (BOM)

If running Linux a good recursive method for detecting these is:

``` sh-session
$ find . -type f -print0 | xargs -0r awk '/^\xEF\xBB\xBF/ {print FILENAME} {nextfile}'
```

Applies to OpenUserJS#200 and OpenUserJS#198
@Martii
Copy link
Member Author

Martii commented Jun 26, 2014

Everyone may see some in ./node_modules/... paths... I'm currently ignoring those since they aren't on the repo here. Haven't tried this in the git preview yet to see if they give the necessary binary dependencies. . They don't... @sizzlemctwizzle Did you want a .sh script added to the repo root that contains this detection method? Windows users will just need to use cygwin with the necessary dependencies but it might be helpful to do this... if you say yes include the filename for me in a reply. Maybe some comic relief with itsdabom.sh? ;) or findbom.sh without being punny. TIA

@Martii Martii added bug and removed PR READY labels Jun 26, 2014
@sizzlemctwizzle
Copy link
Member

Did you want a .sh script added to the repo root that contains this detection method?

Throw it into a "dev" directory. We might want to put other things there in the future.

sizzlemctwizzle added a commit that referenced this pull request Jun 27, 2014
Remove the BOM from the only file I have found it on.
@sizzlemctwizzle sizzlemctwizzle merged commit 0d3d28b into OpenUserJS:master Jun 27, 2014
@Martii
Copy link
Member Author

Martii commented Jun 27, 2014

Throw it into a "dev" directory. We might want to put other things there in the future.

K... I'll have to test it to see if I can ../. instead of . though... we always want to check to root of the repo too.

@Martii Martii deleted the BOMRemoval branch June 27, 2014 02:48
@sizzlemctwizzle
Copy link
Member

cd ../?

@Martii
Copy link
Member Author

Martii commented Jun 27, 2014

$ cd libs
$ find ../. -type f -print0 | xargs -0r awk '/^\xEF\xBB\xBF/ {print FILENAME} {nextfile}'
.././views/header.html
.././node_modules/passport-steam/node_modules/passport-openid/node_modules/openid/OpenID.sln
.././node_modules/passport-steam/node_modules/passport-openid/node_modules/openid/OpenID.njsproj
.././node_modules/passport-aol/node_modules/passport-openid/node_modules/openid/OpenID.sln
.././node_modules/passport-aol/node_modules/passport-openid/node_modules/openid/OpenID.njsproj
.././node_modules/passport-google/node_modules/passport-openid/node_modules/openid/OpenID.sln
.././node_modules/passport-google/node_modules/passport-openid/node_modules/openid/OpenID.njsproj
.././node_modules/passport-yahoo/node_modules/passport-openid/node_modules/openid/OpenID.sln
.././node_modules/passport-yahoo/node_modules/passport-openid/node_modules/openid/OpenID.njsproj

Seems to be working okay with ../.... I haven't remerged current upstream HEAD here yet so it found what I was expecting. If you think it's going to be deeper than this eventually we may want to use cd ../../.. though.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug You've guessed it... this means a bug is reported.
Development

Successfully merging this pull request may close these issues.

2 participants