Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create dev folder for devtools #217

Merged
merged 1 commit into from
Jun 27, 2014
Merged

Create dev folder for devtools #217

merged 1 commit into from
Jun 27, 2014

Conversation

Martii
Copy link
Member

@Martii Martii commented Jun 27, 2014

  • Initialize findbom.sh to search for Byte Order Marks

NOTE: I haven't found anything Command Prompt wise to do this in Windows but there is WSH that I will look into to see if that is possible.


Automerge since this doesn't affect any code anywhere. As per sizzles recommendation at #206 (comment)

* Initialize `findbom.sh` to search for Byte Order Marks

**NOTE**: I haven't found anything Command Prompt wise to do this in Windows but there is WSH that I will look into to see if that is possible.
Martii pushed a commit that referenced this pull request Jun 27, 2014
Create dev folder for devtools
@Martii Martii merged commit e8641a5 into OpenUserJS:master Jun 27, 2014
@Martii Martii added the Feature label Jun 27, 2014
@sizzlemctwizzle
Copy link
Member

fakes3.sh should probably be moved to the dev folder too.

@Martii
Copy link
Member Author

Martii commented Jun 27, 2014

Knew you were going to say that... :P""" ;)

Martii pushed a commit to Martii/OpenUserJS.org that referenced this pull request Jun 27, 2014
@sizzlemctwizzle
Copy link
Member

You might have to edit the command for the storage path if we want preserve scripts we have uploaded locally. But I guess devs could always move their folder (this way would require updating .gitignore).

@Martii
Copy link
Member Author

Martii commented Jun 27, 2014

I am reading greek here at the moment... what do you mean? Is fakes3 going to tuck things in dev folder now? How about you show me what you want done... I'm not real familiar with fakes3 at all... I just invoke it usually and I know it stores script source here.

@Martii
Copy link
Member Author

Martii commented Jun 27, 2014

Is there a parm to tell fakes3 to use one path up? or I could just cd .. too like I did in findbom.sh. I usually Ctrl+C out of fakes3 so putting a cd - won't do any good I think.

@Martii
Copy link
Member Author

Martii commented Jun 27, 2014

ehh... I think we could just tell devs to invoke it from the project root using $ dev/fakes3.sh. That works here.

@sizzlemctwizzle
Copy link
Member

#!/bin/bash
fakes3 -r fakeS3 -p 10001

fakeS3 is the path used for local storage of user scripts by the fakes3 ruby gem. Check your git directory and you'll see it. That path is also in .gitignore.

is fakes3 going to tuck things in dev now?

Correct. And ignore the old directory. Probably doesn't matter since I'm going to wipe the dev database of everything except users.

@Martii
Copy link
Member Author

Martii commented Jun 27, 2014

Do you really want the data store out of the project root and in dev folder then? It doesn't seem like it would really make much difference... when I grep for things it's still going to search those folders. I can just type $ dev/fakes3.sh and nothing else needs to be done but update our CONTRIBUTING.md


Heh just noticed I have a Marti and a marti in there.

Martii pushed a commit to Martii/OpenUserJS.org that referenced this pull request Jun 27, 2014
Martii pushed a commit to Martii/OpenUserJS.org that referenced this pull request Jun 27, 2014
* This is a little easier to type than `./fakes3.sh` at least for me anyways.
* In case they don't do it from there I've already added it to the .gitignore in 20c3e9f20c3e9f9b21ca442f84bedbbdc86cbf4b65aa20f

Applies to OpenUserJS#217
@sizzlemctwizzle
Copy link
Member

Your recently merged PRs work for me.

@Martii
Copy link
Member Author

Martii commented Jun 27, 2014

Sorry... I thought this was trivial... I'll wait on non-docs from now on as much as possible. Glad to hear they work though. :)

@sizzlemctwizzle
Copy link
Member

It's my fault. I get confusing when I'm tired. This was a good change. It
cleans up the root directory a bit.

@Martii Martii added this to the #249 milestone Aug 24, 2014
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants