Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trap failed splits/mappings with prefixes and ReadOnly exceptions #655

Merged
merged 1 commit into from
Jul 2, 2015

Conversation

Martii
Copy link
Member

@Martii Martii commented Jul 2, 2015

  • TODO: Needs further diagnosis in real-time (production watching) and eventually permanently fixed on completion of Decide the fate of custom site/project prefixing in the UserScript metadata block #285
  • oujs - Meta View not exhibiting this behavior... so appears to be a difference in current V8 node versus browser JavaScript (Object) parse
  • Not sure when this occurred as there are scripts uploaded currently (and successfully) that utilize the localizations of @description and @name but is responsible for some of the current server restarts

Production testing at this Unit Test script with some miscellaneous notes.

Possibly some relation to #581

* TODO: Needs further diagnosis in real-time and eventually permanently fixed on completion of OpenUserJS#285
* [oujs - Meta View](https://openuserjs.org/scripts/Marti/oujs_-_Meta_View) **not** exhibiting this behavior... so appears to be a difference in current V8 *node* versus browser JavaScript parse
* Not sure when this occurred as there are scripts uploaded currently that utilizes the localizations of `@description` and `@name` but is responsible for some of the server restarts
@Martii Martii added bug You've guessed it... this means a bug is reported. expedite Immediate and on the front burner. CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. labels Jul 2, 2015
Martii added a commit that referenced this pull request Jul 2, 2015
Trap failed splits/mappings with prefixes and ReadOnly exceptions

Auto-merge
@Martii Martii merged commit bfdfd28 into OpenUserJS:master Jul 2, 2015
@Martii Martii deleted the Issue-285interimFixForLocales branch July 2, 2015 03:01
@Martii Martii added needs testing Anyone can add this but it is primarily there for the Assignee indicating that Testers are wanted. needs mitigation Needs additional followup. and removed expedite Immediate and on the front burner. labels Jul 2, 2015
Martii pushed a commit to Martii/OpenUserJS.org that referenced this pull request Jul 22, 2015
* Crashes the server when removing or never existing `@name` but localized ones exist
* Not entirely sure why one needs to `encodedURI` and the other `decodeURI` but redirect has issue ... possibly a current *node* issue
* Change text to import since it's not uploading a script technically

Additionally applies to OpenUserJS#200, OpenUserJS#226 edge case, and a bit from OpenUserJS#655 detection
@Martii Martii mentioned this pull request Jul 22, 2015
@Martii Martii removed needs mitigation Needs additional followup. needs testing Anyone can add this but it is primarily there for the Assignee indicating that Testers are wanted. labels Aug 25, 2015
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug You've guessed it... this means a bug is reported. CODE Some other Code related issue and it should clearly describe what it is affecting in a comment.
Development

Successfully merging this pull request may close these issues.

1 participant