Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for no @name scripts #674

Merged
merged 1 commit into from
Jul 22, 2015
Merged

Conversation

Martii
Copy link
Member

@Martii Martii commented Jul 22, 2015

  • Crashes the server when removing or never existing @name but localized ones exist
  • Not entirely sure why one needs to encodedURI and the other decodeURI but redirect has issue ... possibly a current node issue (or perhaps express)
  • Change text to import since it's not uploading a script technically

Additionally applies to #200, #226 edge case, and a bit from #655 detection


Mitigation with #285

* Crashes the server when removing or never existing `@name` but localized ones exist
* Not entirely sure why one needs to `encodedURI` and the other `decodeURI` but redirect has issue ... possibly a current *node* issue
* Change text to import since it's not uploading a script technically

Additionally applies to OpenUserJS#200, OpenUserJS#226 edge case, and a bit from OpenUserJS#655 detection
@Martii Martii added bug You've guessed it... this means a bug is reported. CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. labels Jul 22, 2015
Martii added a commit that referenced this pull request Jul 22, 2015
Fix for no `@name` scripts

Auto-merge
@Martii Martii merged commit 610f280 into OpenUserJS:master Jul 22, 2015
@Martii Martii deleted the fixForNoAtNameScripts branch July 22, 2015 13:24
@Martii Martii added the needs mitigation Needs additional followup. label Jul 22, 2015
@Martii Martii added this to the #285 milestone Jul 26, 2015
@Martii Martii removed the needs mitigation Needs additional followup. label Aug 25, 2015
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug You've guessed it... this means a bug is reported. CODE Some other Code related issue and it should clearly describe what it is affecting in a comment.
Development

Successfully merging this pull request may close these issues.

1 participant