Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added no discussions message #405

Merged
merged 1 commit into from
Nov 6, 2014
Merged

Added no discussions message #405

merged 1 commit into from
Nov 6, 2014

Conversation

jerone
Copy link
Contributor

@jerone jerone commented Nov 6, 2014

In addition to #172 & #179

Fixed on:

  • Script issues open & closed
  • Script issues search open & closed
  • Lib issues open & closed
  • Lib issues search open & closed

@jerone jerone added UI Pertains inclusively to the User Interface. PR READY This is used to indicate that a pull request (PR) is ready for evaluation. labels Nov 6, 2014
@Martii
Copy link
Member

Martii commented Nov 6, 2014

In #172 you added all the human readable messages in the views... now you are changing the message to be in the controller for this pr... why the change now and why the inconsistency?

I think we need to take into account about the ease of translations down the line for #18... I would think that the views would be easier to translate than digging around in the controllers... but I haven't thought that far ahead yet.

@jerone
Copy link
Contributor Author

jerone commented Nov 6, 2014

@Martii commented on 6 nov. 2014 20:35 CET:

In #172 you added all the human readable messages in the views... now you are changing the message to be in the controller for this pr... why the change now and why the inconsistency?

After some comments here, this has been added on a few more places then not:

More info here: #179

@jerone
Copy link
Contributor Author

jerone commented Nov 6, 2014

I'm removing the PR READY tag as I found one other place; the libs.

@jerone jerone removed the PR READY This is used to indicate that a pull request (PR) is ready for evaluation. label Nov 6, 2014
@jerone
Copy link
Contributor Author

jerone commented Nov 6, 2014

@jerone commented on 6 nov. 2014 20:50 CET:

I'm removing the PR READY tag as I found one other place; the libs.

My bad, forgot that I was on another branch.

@jerone jerone added the PR READY This is used to indicate that a pull request (PR) is ready for evaluation. label Nov 6, 2014
@Martii
Copy link
Member

Martii commented Nov 6, 2014

Thanks for the addition of #179... now that makes more sense... also mentioned in #178. Helpful to have a history of this in each one although can be a bit overwhelming to think back that far sometimes. :)

+1 then since it is consistent.

Martii added a commit that referenced this pull request Nov 6, 2014
Added no discussions message

Auto-merge
@Martii Martii merged commit 9937d2d into OpenUserJS:master Nov 6, 2014
@jerone
Copy link
Contributor Author

jerone commented Nov 6, 2014

@Martii commented on 6 nov. 2014 21:13 CET:

... Helpful to have a history of this in each one although can be a bit overwhelming to think back that far sometimes. :)

Yes, had to think hard for it 😄

@Martii Martii removed the PR READY This is used to indicate that a pull request (PR) is ready for evaluation. label Nov 6, 2014
@jerone jerone deleted the empty-lists branch November 25, 2014 07:58
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
UI Pertains inclusively to the User Interface.
Development

Successfully merging this pull request may close these issues.

2 participants