Refactor/converse #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NeonJarbas
force-pushed
the
refactor/converse
branch
2 times, most recently
from
0cc12d7 to
b0534f2
Compare
NeonJarbas
force-pushed
the
refactor/converse
branch
from
b0534f2 to
e1ed7d8
Compare
NeonJarbas
force-pushed
the
refactor/converse
branch
2 times, most recently
from
184068a to
620f0bb
Compare
JarbasAl
force-pushed
the
refactor/converse
branch
from
620f0bb to
44d579b
Compare
JarbasAl
added a commit
that referenced
this pull request
Nov 26, 2021
make converse event based, it was a little odd because it was the only code from MycroftSkill called outside of the class itself The event based approach also adds support for external skills, eg, Hivemind and OVOSAbstractApp refactored converse process into a dedicated class like adapt/padatious/fallbacks added a new converse acknowledge bus message, now converse is only called for skills where converse is implemented. skills are removed from active skill list if - skill does not have converse capabilities - skill was unloaded/disconnected - skill does not want to converse at this time
JarbasAl
added a commit
that referenced
this pull request
Jan 24, 2022
make converse event based, it was a little odd because it was the only code from MycroftSkill called outside of the class itself The event based approach also adds support for external skills, eg, Hivemind and OVOSAbstractApp refactored converse process into a dedicated class like adapt/padatious/fallbacks added a new converse acknowledge bus message, now converse is only called for skills where converse is implemented. skills are removed from active skill list if - skill does not have converse capabilities - skill was unloaded/disconnected - skill does not want to converse at this time
JarbasAl
added a commit
that referenced
this pull request
Feb 1, 2022
make converse event based, it was a little odd because it was the only code from MycroftSkill called outside of the class itself The event based approach also adds support for external skills, eg, Hivemind and OVOSAbstractApp refactored converse process into a dedicated class like adapt/padatious/fallbacks added a new converse acknowledge bus message, now converse is only called for skills where converse is implemented. skills are removed from active skill list if - skill does not have converse capabilities - skill was unloaded/disconnected - skill does not want to converse at this time
JarbasAl
added a commit
that referenced
this pull request
Feb 1, 2022
make converse event based, it was a little odd because it was the only code from MycroftSkill called outside of the class itself The event based approach also adds support for external skills, eg, Hivemind and OVOSAbstractApp refactored converse process into a dedicated class like adapt/padatious/fallbacks added a new converse acknowledge bus message, now converse is only called for skills where converse is implemented. skills are removed from active skill list if - skill does not have converse capabilities - skill was unloaded/disconnected - skill does not want to converse at this time
JarbasAl
force-pushed
the
refactor/converse
branch
from
44d579b to
67b7f85
Compare
NeonDaniel
reviewed
Feb 1, 2022
Member
NeonDaniel
left a comment
NeonDaniel
left a comment
There was a problem hiding this comment.
Few comments for consideration
make converse event based, it was a little odd because it was the only code from MycroftSkill called outside of the class itself The event based approach also adds support for external skills, eg, Hivemind and OVOSAbstractApp refactored converse process into a dedicated class like adapt/padatious/fallbacks added a new converse acknowledge bus message, now converse is only called for skills where converse is implemented. skills are removed from active skill list if - skill does not have converse capabilities - skill was unloaded/disconnected - skill does not want to converse at this time
JarbasAl
force-pushed
the
refactor/converse
branch
from
2dc066a to
b4f396a
Compare
NeonDaniel
approved these changes
Feb 2, 2022
Member
NeonDaniel
left a comment
NeonDaniel
left a comment
There was a problem hiding this comment.
Untested but changes look good
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make converse event based, it was a little odd because it was the only code from MycroftSkill called outside of the skill itself
The event based approach also adds support for external skills, eg, Hivemind and OVOSAbstractApp
refactored converse process into a single class like adapt/padatious/fallbacks
added a new converse acknowledge bus message, now converse is only called for skills where converse is implemented.
skills are removed from active skill list if