feat/microphone plugins + update logging and documentation #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add docstrings to some methods Reformatting for PEP
Logging and annotation in `hotwords`
Annotate and add some thread safety to `AlsaMicrophone` More debugging around WW detection Prevent exceptions while managing microphone `stop`
JarbasAl
reviewed
May 19, 2023
JarbasAl
reviewed
May 19, 2023
Prevent restarting MessageBusClient objects
JarbasAl
changed the title
JarbasAl
reviewed
May 22, 2023
|
Validated with OpenVoiceOS/ovos-plugin-manager#155 |
Remove unnecessary config override in service init
JarbasAl
approved these changes
May 22, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor to import from OPM
Add some logs to debug listener state and activity
Adds docstrings and comments
Includes some PEP formatting
Includes minor bugfixes/improvements