Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MicrophoneFactory config handling #155

Merged
merged 4 commits into from
May 22, 2023

Conversation

NeonDaniel
Copy link
Member

Fix MicrophoneFactory to expand configuration for compat with dataclass base Microphone class
Updates tests from #154

@codecov
Copy link

codecov bot commented May 22, 2023

Codecov Report

❗ No coverage uploaded for pull request base (dev@7eba4f0). Click here to learn what that means.
The diff coverage is n/a.

@@          Coverage Diff          @@
##             dev    #155   +/-   ##
=====================================
  Coverage       ?   0.00%           
=====================================
  Files          ?      55           
  Lines          ?    3927           
  Branches       ?       0           
=====================================
  Hits           ?       0           
  Misses         ?    3927           
  Partials       ?       0           

@JarbasAl JarbasAl merged commit f76b16f into dev May 22, 2023
@JarbasAl JarbasAl deleted the FIX_CreateMicrophoneConfigHandling branch May 22, 2023 19:47
@github-actions github-actions bot mentioned this pull request Jun 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants