[Feature]: New Shader Support (Engine) #1406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
yohjimane
commented
Jul 24, 2023
•
yohjimane
commented
- Support Ascii's screen space shaders
- Support Kennedith/KennShade's enhanced shaders
- Support Beef's NVG shaders
- Support Anomaly gasmask shaders
14 tasks
yohjimane
force-pushed
the
feature/shader-support-engine
branch
3 times, most recently
from
f7097fc to
df15d2e
Compare
yohjimane
force-pushed
the
feature/shader-support-engine
branch
11 times, most recently
from
63c6100 to
f4e6fbc
Compare
Xottab-DUTY
added
Enhancement
Player Experience
Call of Pripyat
…eef's NVG shaders - thx LVutner!
…rops_control, mask_control
yohjimane
force-pushed
the
feature/shader-support-engine
branch
from
f4e6fbc to
6c3a3b4
Compare
|
Due to size, this branch will no longer receive any more updates. Any additional updates for this functionality (e.g. UI for new options, script functions ported to engine, etc) will be in separate PRs. As of now, the support for using new shaders is in place, so I consider this feature complete. |
|
@Xottab-DUTY |
Any reviews are appreciated. But we currently have FPS regression after multithreaded renderer changes, and little graphical bugs when multithreading is enabled. I want to make sure that I won't add any additional work to @vTurbine (which I asked to fix these problems), so I'm waiting until at least FPS regression is fixed before merging this PR. |
Xottab-DUTY
force-pushed
the
feature/shader-support-engine
branch
from
039211d to
bff6f77
Compare
vis cleanup is done in CDetailManager::UpdateVisibleM. For reference – d6e2d6a.
Xottab-DUTY
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.