-
-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature]: Support Ascii1457's screen space shaders #1402
Conversation
4d2ce12
to
4241797
Compare
4241797
to
7eb0c24
Compare
ba93a1c
to
8a111ff
Compare
All shaders are now loading properly (or at least not crashing!) The only shader that does not work currently is the DoF shader. This depends on a script, which depends on some more functionality to be ported form anomaly (mainly, missing script callbacks) As of now, this is feature complete and ready for review. |
I've tested this, works great for the most part. Two questions if you don't mind:
|
Hey @CasualDev242
e.g. some good default values Edit: on further testing, i found enabling ssfx_grass_interactive while in-game can cause a hang. As a bandaid, the default values of ssfx_grass_interactive have changed to: |
e472211
to
d4d39bb
Compare
Hey @CasualDev242, thanks for calling out IL - i checked by uncommenting On anomaly, I did the same thing and also didn't see any difference, so maybe that debug mode doesn't work properly. I reached out to Ascii to ask how to validate indirect lighting, hopefully will hear back soon! |
b84aa42
to
37dd567
Compare
37dd567
to
0396a78
Compare
b422320
to
187827e
Compare
…eef's NVG shaders - thx LVutner!
187827e
to
4e26eea
Compare
@CasualDev242 Hey, indirect lighting and dof are now working with the latest changes. Dof support is basic and not dynamic yet. We are splitting up the gamedata and engine changes into separate merges to capture some new scope, and for easier review, so i will be closing this merge. |
Credits: Ascii1457, LVutner, Anomaly Team
Bootable, but still WIP, needs additional engine code ported from anomaly
Features to verify: