Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Support Ascii1457's screen space shaders #1402

Closed
wants to merge 25 commits into from

Conversation

yohjimane
Copy link
Contributor

@yohjimane yohjimane commented Jul 17, 2023

Credits: Ascii1457, LVutner, Anomaly Team

Bootable, but still WIP, needs additional engine code ported from anomaly

Features to verify:

  • Ambient occlusion
  • Screen space shadows
  • Screen space reflections
  • Water reflections
  • Rain puddles
  • Depth of field
  • Indirect Light
  • Additional shadow features
  • Interactive grass
  • Shadow fixes
  • Skybox debanding
  • Flora fixes and improvements
  • Fog
  • Volumetric sun ray fixes

@github-actions github-actions bot added AI Artificial Intelligence External (3rd party) This issue is related to external component used by our project. Renderer labels Jul 17, 2023
@yohjimane yohjimane changed the title WIP: Feature/screen space shaders WIP: Support Ascii1457's screen space shaders Jul 17, 2023
@yohjimane yohjimane force-pushed the feature/screen-space-shaders branch 2 times, most recently from 4d2ce12 to 4241797 Compare July 17, 2023 11:59
@github-actions github-actions bot removed the External (3rd party) This issue is related to external component used by our project. label Jul 17, 2023
@yohjimane yohjimane force-pushed the feature/screen-space-shaders branch from 4241797 to 7eb0c24 Compare July 17, 2023 12:03
@yohjimane yohjimane force-pushed the feature/screen-space-shaders branch from ba93a1c to 8a111ff Compare July 20, 2023 11:15
@yohjimane
Copy link
Contributor Author

All shaders are now loading properly (or at least not crashing!)

The only shader that does not work currently is the DoF shader. This depends on a script, which depends on some more functionality to be ported form anomaly (mainly, missing script callbacks)

As of now, this is feature complete and ready for review.

@yohjimane yohjimane changed the title WIP: Support Ascii1457's screen space shaders Support Ascii1457's screen space shaders Jul 22, 2023
@yohjimane yohjimane changed the title Support Ascii1457's screen space shaders [Feature]: Support Ascii1457's screen space shaders Jul 22, 2023
@CasualDev242
Copy link
Contributor

I've tested this, works great for the most part. Two questions if you don't mind:

  1. Are you sure Indirect Illumination is working? I've tried cranking up values (after deleting shader cache), and even enabling debug mode, and don't notice any difference.
  2. Is interactive grass supposed to be functional yet, or require further implementation? The grass isn't moving upon collision.

@yohjimane
Copy link
Contributor Author

yohjimane commented Jul 22, 2023

Hey @CasualDev242

  1. I will need to test this further.

  2. Interactive grass can be configured as such:
    ssfx_grass_interactive = player collision enable (0-1), max collisions (0-15), max distance (0-5000), mutant collision enable (0-1)

e.g. some good default values
ssfx_grass_interactive = 1,15,3000,1

Edit: on further testing, i found enabling ssfx_grass_interactive while in-game can cause a hang. As a bandaid, the default values of ssfx_grass_interactive have changed to:
0,0,2000,1 -> 1,8,2000,1

@yohjimane yohjimane force-pushed the feature/screen-space-shaders branch from e472211 to d4d39bb Compare July 22, 2023 16:58
@yohjimane
Copy link
Contributor Author

Hey @CasualDev242, thanks for calling out IL - i checked by uncommenting G_IL_DEBUG_MODE in shaders, and didn't see any difference.

On anomaly, I did the same thing and also didn't see any difference, so maybe that debug mode doesn't work properly. I reached out to Ascii to ask how to validate indirect lighting, hopefully will hear back soon!

@yohjimane yohjimane force-pushed the feature/screen-space-shaders branch from b84aa42 to 37dd567 Compare July 22, 2023 18:21
@yohjimane yohjimane force-pushed the feature/screen-space-shaders branch from 37dd567 to 0396a78 Compare July 22, 2023 18:33
@yohjimane yohjimane force-pushed the feature/screen-space-shaders branch 4 times, most recently from b422320 to 187827e Compare July 23, 2023 16:30
@yohjimane yohjimane force-pushed the feature/screen-space-shaders branch from 187827e to 4e26eea Compare July 23, 2023 16:32
@yohjimane
Copy link
Contributor Author

yohjimane commented Jul 24, 2023

@CasualDev242 Hey, indirect lighting and dof are now working with the latest changes. Dof support is basic and not dynamic yet.

We are splitting up the gamedata and engine changes into separate merges to capture some new scope, and for easier review, so i will be closing this merge.

Superseded by both: #1406 #1407

@yohjimane yohjimane closed this Jul 24, 2023
@yohjimane yohjimane deleted the feature/screen-space-shaders branch August 28, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support new shaders from Ascii1457, Kennshade, TheRealBeef, Anomaly Team
3 participants