Improve mocks #1146
Merged
Improve mocks #1146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eleased-package-#1141
…emove-dual-dispatchers
…eat/remove-mocks-from-released-package-#1141
* feat: remove modules * fix: mock * fix: linter * fix: tests * fix: mock * feat: apply review suggestions
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1146 +/- ##
=======================================
Coverage 91.51% 91.51%
=======================================
Files 46 46
Lines 1178 1178
=======================================
Hits 1078 1078
Misses 100 100
Continue to review full report in Codecov by Sentry.
|
…om-released-package-#1141
…eat/remove-mocks-from-released-package-#1141
…eat/remove-mocks-from-released-package-#1141
…eat/remove-mocks-from-released-package-#1141
Comment on lines
+24
to
+25
| scarb 2.8.4 (2aa4e193e 2024-10-07) | ||
| cairo: 2.8.4 (https://crates.io/crates/cairo-lang-compiler/2.8.4) |
Comment on lines
+42
to
+44
| [[test]] | ||
| name = "openzeppelin_account_unittest" | ||
| build-external-contracts = [ |
There was a problem hiding this comment.
Is the name a requirement? Not that I'm against it if it's not, I'm just curious
There was a problem hiding this comment.
It is, because of a known issue with foundry and scarb.
Comment on lines
-1
to
-15
| mod mocks; | ||
|
|
||
| #[cfg(test)] | ||
| mod test_account; | ||
| #[cfg(test)] | ||
| mod test_erc1155; | ||
| #[cfg(test)] | ||
| mod test_erc20; | ||
| #[cfg(test)] | ||
| mod test_erc721; | ||
| #[cfg(test)] | ||
| mod test_eth_account; | ||
| #[cfg(test)] | ||
| mod test_universal_deployer; | ||
| #[cfg(test)] |
There was a problem hiding this comment.
Soooo much better 😄
andrew-fleming
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1141
Depends on #1163
This PR centralizes mocks into the
test_commonpackage to avoid repetition and make them easier to maintain.