-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove DualCase dispatchers #1163
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1163 +/- ##
==========================================
+ Coverage 88.87% 91.51% +2.63%
==========================================
Files 57 46 -11
Lines 1375 1178 -197
==========================================
- Hits 1222 1078 -144
+ Misses 153 100 -53
... and 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
* feat: remove modules * fix: mock * fix: linter * fix: tests * fix: mock * feat: apply review suggestions
…emove-dual-dispatchers
* feat: update docs * feat: update CHANGELOG * fix: typo * fix: mod * feat: remove unused imports * fix: README * feat: remove selectors * Update docs/modules/ROOT/pages/interfaces.adoc Co-authored-by: Andrew Fleming <fleming.andrew@protonmail.com> * feat: add mention and link to dispatcher types * feat: remove import * Update docs/modules/ROOT/pages/interfaces.adoc Co-authored-by: Andrew Fleming <fleming.andrew@protonmail.com> * fix: README --------- Co-authored-by: Andrew Fleming <fleming.andrew@protonmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Fixes #1128
PR Checklist