Skip to content

Conversation

@ericglau
Copy link
Member

@ericglau ericglau commented Jan 17, 2025

  • Removes array.prototype.flatmap and array.prototype.flat since flat and flatMap are now supported in current LTS versions of Node JS.
  • Removes unused bn.js and ethereum-cryptography from Cairo Wizard package.

@socket-security
Copy link

socket-security bot commented Jan 17, 2025

@socket-security
Copy link

socket-security bot commented Jan 17, 2025

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/ws@7.4.6, npm/undici@5.28.4

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

@ericglau
Copy link
Member Author

@SocketSecurity ignore npm/ws@7.4.6
Unrelated to this PR, and see #421 (comment)

@ericglau
Copy link
Member Author

@SocketSecurity ignore npm/undici@5.28.4

This dependency occurs in downloads for Hardhat packages, due to the following dependency tree:

@nomicfoundation/hardhat-toolbox@5.0.0
- @nomicfoundation/hardhat-verify@2.0.12
  - undici@5.28.4

This seems expected as the package is an HTTP client but is only used when verifying source code through Hardhat.

@ericglau ericglau marked this pull request as ready for review January 20, 2025 15:59
Copy link
Member

@ericnordelo ericnordelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ericglau ericglau merged commit 6284e0b into OpenZeppelin:master Jan 20, 2025
9 checks passed
@ericglau ericglau deleted the removedeps branch January 20, 2025 18:18
@talentlessguy
Copy link

seems like the changed weren't published

is it possible to npm publish them?

@ericglau
Copy link
Member Author

@talentlessguy Published to @openzeppelin/wizard@0.5.0 and @openzeppelin/wizard-cairo@0.21.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants