Skip to content

Conversation

@ericglau
Copy link
Member

@ericglau ericglau commented Jan 30, 2025

When ERC20/Stablecoin/Real-World Asset's Premint option is enabled, it currently mints to msg.sender, which is not consistent with current best practices.

This PR changes it to mint to a recipient constructor argument or initializer argument instead.

Note that this is potentially a minor breaking change for users who deploy with this option.

Depends on #434, so only commits starting from e0b2d46 and later need to be reviewed for this PR.
Fixes #73

@ericglau ericglau requested a review from a team January 30, 2025 21:03
@socket-security
Copy link

socket-security bot commented Feb 5, 2025

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@nomicfoundation/hardhat-toolbox@5.0.0 environment Transitive: eval, filesystem, network, shell, unsafe +437 149 MB kanej
npm/@openzeppelin/hardhat-upgrades@3.9.0 filesystem Transitive: environment, eval, network, shell, unsafe +230 55 MB ericglau
npm/hardhat@2.22.16 🔁 npm/hardhat@2.22.18 Transitive: eval, unsafe +256 199 MB kanej

🚮 Removed packages: npm/@rollup/plugin-alias@5.1.1, npm/@rollup/plugin-commonjs@28.0.2, npm/@rollup/plugin-json@6.1.0, npm/@rollup/plugin-node-resolve@16.0.0, npm/@rollup/plugin-replace@6.0.2, npm/@rollup/plugin-typescript@12.1.2, npm/@types/file-saver@2.0.7, npm/@types/istanbul-lib-coverage@2.0.6, npm/@types/istanbul-lib-report@3.0.3, npm/@types/istanbul-reports@1.1.2, npm/@types/resize-observer-browser@0.1.11, npm/@types/yargs-parser@21.0.3, npm/@types/yargs@13.0.12, npm/autoprefixer@10.4.20, npm/ava@6.2.0, npm/bluebird@3.7.2, npm/camelcase@5.3.1, npm/cliui@5.0.0, npm/cross-spawn@6.0.6, npm/decamelize@1.2.0, npm/emoji-regex@7.0.3, npm/end-of-stream@1.4.4, npm/execa@1.0.0, npm/file-saver@2.0.5, npm/find-up@3.0.0, npm/get-stream@4.1.0, npm/highlight.js@11.11.1, npm/highlightjs-cairo@0.4.0, npm/highlightjs-solidity@2.0.6, npm/is-stream@1.1.0, npm/jest-changed-files@24.9.0, npm/jszip@3.10.1, npm/locate-path@3.0.0, npm/nice-try@1.0.5, npm/npm-run-path@2.0.2, npm/p-finally@1.0.0, npm/p-limit@2.3.0, npm/p-locate@3.0.0, npm/p-try@2.2.0, npm/path-browserify@1.0.1, npm/path-exists@3.0.0, npm/postcss-load-config@6.0.1, npm/postcss@8.5.1, npm/pump@3.0.2, npm/require-main-filename@2.0.0, npm/rimraf@5.0.10, npm/rollup-plugin-livereload@2.0.5, npm/rollup-plugin-styles@4.0.0, npm/rollup-plugin-svelte@7.2.2, npm/rollup-plugin-terser@7.0.2, npm/rollup@4.34.3, npm/set-blocking@2.0.0, npm/shebang-command@1.2.0, npm/shebang-regex@1.0.0, npm/sirv-cli@3.0.0, npm/split@1.0.1, npm/strip-eof@1.0.0, npm/through@2.3.8, npm/which-module@2.0.1, npm/wrap-ansi@5.1.0, npm/wsrun@5.2.4, npm/y18n@4.0.3, npm/yargs-parser@13.1.2, npm/yargs@13.3.2

View full report↗︎

@socket-security
Copy link

socket-security bot commented Feb 5, 2025

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/ws@7.4.6, npm/undici@5.28.4

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

@ericglau
Copy link
Member Author

ericglau commented Feb 5, 2025

@SocketSecurity ignore npm/ws@7.4.6
Unrelated to this PR, and see #421 (comment)

@ericglau
Copy link
Member Author

ericglau commented Feb 5, 2025

@SocketSecurity ignore npm/undici@5.28.4

Unrelated to this PR, see #430 (comment)

@github-actions github-actions bot mentioned this pull request Jun 19, 2025
This was referenced Aug 12, 2025
@github-actions github-actions bot mentioned this pull request Aug 28, 2025
This was referenced Sep 16, 2025
This was referenced Oct 29, 2025
This was referenced Nov 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use constructor parameter for ERC20 Premint

2 participants