Skip to content

Address feedback for Account #523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 23, 2025
Merged

Address feedback for Account #523

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5ec5d8f
Address feedback for Account
ernestognw Apr 23, 2025
482e9d7
Update snapshots
ernestognw Apr 23, 2025
13e19f6
Improve test cases
ernestognw Apr 23, 2025
b799bac
Update order in which signature validation is added
ernestognw Apr 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion packages/core/solidity/src/account.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ test('account API assert defaults', async t => {
t.is(account.print(account.defaults), account.print());
});

for (const signer of [undefined, 'ERC7702', 'ECDSA', 'P256', 'RSA'] as const) {
for (const signer of [false, 'ERC7702', 'ECDSA', 'P256', 'RSA'] as const) {
let title = 'Account';
if (signer) {
title += ` with Signer${signer}`;
Expand Down Expand Up @@ -102,6 +102,18 @@ for (const signer of [undefined, 'ERC7702', 'ECDSA', 'P256', 'RSA'] as const) {
ERC7579Modules: 'AccountERC7579',
});

testAccount(`${title} with ERC7579 with ERC1271`, {
signer,
ERC7579Modules: 'AccountERC7579',
signatureValidation: 'ERC1271',
});

testAccount(`${title} with ERC7579 with ERC7739`, {
signer,
ERC7579Modules: 'AccountERC7579',
signatureValidation: 'ERC7739',
});

testAccount(`${title} with ERC7579 hooks`, {
signer,
ERC7579Modules: 'AccountERC7579Hooked',
Expand Down
Loading
Loading