N-02: reorder allowances omnibus

[arr00]

Summary by CodeRabbit

• Refactor
  • Internal code reorganization to improve structure and maintainability. No functional changes or new features.

[netlify]

✅ Deploy Preview for confidential-tokens ready!

Name	Link
🔨 Latest commit	3a06a24
🔍 Latest deploy log	https://app.netlify.com/projects/confidential-tokens/deploys/69139aa06aa04f0008349681
😎 Deploy Preview	https://deploy-preview-250--confidential-tokens.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[coderabbitai]

Walkthrough

Reorders the declaration of the transferred local variable in _confidentialTransferFromAndCallOmnibus to occur after ACL allowance blocks for sender and recipient instead of before. No behavioral changes; the variable is still emitted and used identically.

Changes

Cohort / File(s)	Summary
Variable Declaration Reordering contracts/token/ERC7984/extensions/ERC7984Omnibus.sol	Moves transferred variable declaration from before ACL allowance blocks to after, maintaining functional equivalence

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

• Omnibus Extension #186: Directly related as it introduced the _confidentialTransferFromAndCallOmnibus function that is being modified in this PR.

Suggested reviewers

• james-toussaint

Poem

🐰 A variable moves, yet logic stays true,
Reordered with care, no harm comes through.
The bits rearrange in the order they go,
Transferred remains where it needs to flow! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly identifies the specific change: reordering allowance logic in the omnibus contract.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 973820f and 3a06a24.

📒 Files selected for processing (1)

• contracts/token/ERC7984/extensions/ERC7984Omnibus.sol (1 hunks)

🧰 Additional context used

🧠 Learnings (3)

📓 Common learnings

Learnt from: arr00
Repo: OpenZeppelin/openzeppelin-confidential-contracts PR: 186
File: contracts/token/ERC7984/extensions/ERC7984Omnibus.sol:140-167
Timestamp: 2025-09-15T14:43:25.644Z
Learning: In ERC7984Omnibus callback functions like confidentialTransferFromAndCallOmnibus, the encrypted sender and recipient addresses are not passed to the callback recipient - only the standard transfer parameters (omnibusFrom, omnibusTo, amount, data) are passed. The ACL grants for the encrypted addresses are for omnibus event emission and future access, not for callback usage.

📚 Learning: 2025-09-15T14:43:25.644Z

Learnt from: arr00
Repo: OpenZeppelin/openzeppelin-confidential-contracts PR: 186
File: contracts/token/ERC7984/extensions/ERC7984Omnibus.sol:140-167
Timestamp: 2025-09-15T14:43:25.644Z
Learning: In ERC7984Omnibus callback functions like confidentialTransferFromAndCallOmnibus, the encrypted sender and recipient addresses are not passed to the callback recipient - only the standard transfer parameters (omnibusFrom, omnibusTo, amount, data) are passed. The ACL grants for the encrypted addresses are for omnibus event emission and future access, not for callback usage.

Applied to files:

• contracts/token/ERC7984/extensions/ERC7984Omnibus.sol

📚 Learning: 2025-09-22T09:21:34.470Z

Learnt from: james-toussaint
Repo: OpenZeppelin/openzeppelin-confidential-contracts PR: 160
File: test/token/ERC7984/extensions/ERC7984Rwa.test.ts:474-479
Timestamp: 2025-09-22T09:21:34.470Z
Learning: In ERC7984Freezable force transfers, the frozen balance is reset to the new balance only when the transferred amount exceeds the available balance (balance - frozen). If the transferred amount is within the available balance, the frozen amount remains unchanged. This is implemented via FHE.select(FHE.gt(encryptedAmount, confidentialAvailable(account)), confidentialBalanceOf(account), frozen).

Applied to files:

• contracts/token/ERC7984/extensions/ERC7984Omnibus.sol

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

• GitHub Check: slither
• GitHub Check: coverage
• GitHub Check: tests

🔇 Additional comments (1)

contracts/token/ERC7984/extensions/ERC7984Omnibus.sol (1)

199-200: LGTM! Improved consistency with the sibling function.

Moving the transferred variable declaration to after the ACL allowances for sender and recipient aligns this function with the pattern used in _confidentialTransferFromOmnibus (line 177), improving code consistency and logical ordering of operations.

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[james-toussaint]

Ok for consistency ✅