-
Notifications
You must be signed in to change notification settings - Fork 11.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenZeppelin Contracts v3.0 Pending Changes #2086
Comments
We should review the situation around |
Hi @frangio and @nventuro . Some while ago I mentioned some prospective issues with regards to solc 0.6 new I noticed that SafeERC20 has been upgraded to solc 0.6, but the methods are still internal. Do you intend to release/deploy a SafeERC20 library that is ready for use with |
@gitpusha That's interesting. |
#2118 |
Is #1745 something that may require breaking changes? It seems that we can either add a new separate contract (not breaking) or modify the existing |
I believe it can be implemented as an extension in a non-breaking way, so I don't think we need to worry about it now. |
I want to review the naming of libraries. It is currently inconsistent, some are singular and others are plural. Should it be plural or singular? |
Hi @frangio. Sorry for never replying to this. I lost track of this issue. The reasons for using try catch is
However, you are right. There are several other ways of achieving the same without changing this library for everyone. I will pursue one of them myself and might open an issue about it. Thank you! |
Closing in favor of the milestone. |
This is a non-comprehensive list of changes we want to introduce in the v3.0, the upcoming major release. We will use this opportunity to introduce some breaking changes by removing contracts we don't see much demand for (such as Crowdsales), and improving others we could can be done better (like Roles and Access Control in general).
For more information about the v3.0 release, head to our roadmap.
ERC20Detailed
, possiblyERC721Metadata
andERC721Enumerable
)drafts
and either remove or promote out of therecontract
sinterface
s instead (see here)Address.toPayable()
(Address.toPayable no longer needed since Solidity 0.6.0 #2118)internal
functions in contracts but not in librariesabstract
(such asOwnable
andERC20
)Strings
,Counters
,EnumerableSet
...ECDSA.recover
The text was updated successfully, but these errors were encountered: