Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ERC*Pausable doesn't have a public pause() and unpause() functions #4006

Open
ernestognw opened this issue Jan 27, 2023 · 4 comments
Open

ERC*Pausable doesn't have a public pause() and unpause() functions #4006

ernestognw opened this issue Jan 27, 2023 · 4 comments
Labels
breaking change Changes that break backwards compatibility of the public API.
Milestone

Comments

@ernestognw
Copy link
Member

ernestognw commented Jan 27, 2023

🧐 Motivation
Currently, ERC20Pausable, ERC721Pausable and ERC1155Pausable doesn't have public or external pause and unpause mechanisms.

This dates since v3.0 (some context here, here, and here), in which Pausable became abstract to allow for supporting both AccessControl and Ownable as access control mechanisms.

This might need discussion before moving forward for 5.0

@ernestognw ernestognw added the breaking change Changes that break backwards compatibility of the public API. label Jan 27, 2023
@ernestognw ernestognw added this to the 5.0 milestone Jan 27, 2023
@ernestognw
Copy link
Member Author

Tested the repo with:

function pause() external virtual;
function unpause() external virtual;

Makes compilation only fail with ERC20PresetMinterPauser, and that's in our Roadmap for deprecations, so I'm leaving this for further discussion.

@frangio
Copy link
Contributor

frangio commented Jan 27, 2023

Note that this also applies to ERC721Pausable and ERC1155Pausable.

@ernestognw ernestognw changed the title ERC20Pausable doesn't have a public pause() and unpause() functions ERC*Pausable doesn't have a public pause() and unpause() functions Jan 28, 2023
@dirtycajunrice
Copy link

it is more code to override the public unsafe function than it is to implement it properly calling the internal function. My vote is no change

@Amxx Amxx modified the milestones: 5.0, 5.1 Oct 11, 2023
@Amxx
Copy link
Collaborator

Amxx commented Oct 11, 2023

Not in 5.0. Candidate for 5.x

@cairoeth cairoeth modified the milestones: 5.1, 5.x Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Changes that break backwards compatibility of the public API.
Projects
None yet
Development

No branches or pull requests

5 participants