Add ERC*Pausable warning for public pausing mechanism
#4007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2a86021 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ernestognw
changed the title
ERC20Pausable warning for public pausing mechanism
Amxx
previously approved these changes
Jan 27, 2023
|
This needs to be applied in ERC721Pausable and ERC1155Pausable as well. |
frangio
reviewed
Jan 27, 2023
Co-authored-by: Francisco <fg@frang.io>
Thanks for the heads up. I added them with the same message proposed. |
ernestognw
changed the title
ERC20Pausable warning for public pausing mechanismERC*Pausable warning for public pausing mechanism
Co-authored-by: Francisco <fg@frang.io>
frangio
approved these changes
Jan 28, 2023
frangio
pushed a commit
that referenced
this pull request
Jan 31, 2023
Co-authored-by: Francisco <fg@frang.io> (cherry picked from commit 1684c57)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mitigates #4006, although it doesn't solve, makes it clear that there are missing functions.