Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adhere to naming convention #2150

Merged
merged 8 commits into from
Mar 27, 2020
Merged

Adhere to naming convention #2150

merged 8 commits into from
Mar 27, 2020

Conversation

nventuro
Copy link
Contributor

@nventuro nventuro commented Mar 26, 2020 •
edited
Loading

Part of #2086.

This uses the work done in protofire/solhint#90 to add the private-vars-leading-underscore linter rule, which requires that:

  • all private and internal contract functions and variables have a leading underscore
  • all public contract functions and internal library functions don't have a leading underscore

I also fixed instances where we're not adhering to this convention.

@nventuro nventuro requested a review from frangio March 26, 2020 18:53
frangio
frangio approved these changes Mar 27, 2020
View reviewed changes
Copy link
Contributor

@frangio frangio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nventuro nventuro merged commit 97894a1 into OpenZeppelin:master Mar 27, 2020
@nventuro nventuro deleted the naming-convention branch March 27, 2020 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frangio frangio frangio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nventuro @frangio