-
Notifications
You must be signed in to change notification settings - Fork 11.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize Strings.equal #4262
Optimize Strings.equal #4262
Conversation
🦋 Changeset detectedLatest commit: a01072f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Thanks for the clear title. 😛 This is definitely good, we just need a changeset. Can you add it ( |
I've added the changeset. Sorry for not doing it before, this PR seemed too small to litter the changelog with it, my misake 🤷 BTW you've added this PR to the 5.0 milestone, does it mean that it won't be available in 4.9.1 and 4.10 if such versions ever exist? I'm not a project maintainer, but it seems strange, it's not a breaking change or even a new feature. |
|
Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicee, thanks!
Fixes #NONE
It's a really small optimization avoiding hashing strings when they're obviously different.
PR Checklist
npx changeset add
)