Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): Fix gripper recovery loop #17241

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

mjhuff
Copy link
Contributor

@mjhuff mjhuff commented Jan 10, 2025

Closes RQA-3841

Overview

Fixes a bug when selecting the "no" option during the "is gripper holding labware" prompt. The command sequencing was slightly off, causing routing issues. Terminating an "in motion" view restores the previous view before the "in motion" view, which causes the loop.

Current Behavior

Screen.Recording.2025-01-10.at.10.19.43.AM.mov

Fixed Behavior

Screen.Recording.2025-01-10.at.10.16.19.AM.mov

Test Plan and Hands on Testing

  • See videos.

Changelog

  • Fixed a bug during gripper recovery in which selecting "no labware in jaws" causes a loop.

Risk assessment

very low

@mjhuff mjhuff requested a review from a team as a code owner January 10, 2025 15:26
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops!

Copy link
Contributor

@TamarZanzouri TamarZanzouri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@mjhuff mjhuff merged commit b13cd27 into chore_release-8.3.0 Jan 10, 2025
36 checks passed
@mjhuff mjhuff deleted the app_fix-gripper-recovery-loop branch January 10, 2025 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants