Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): Fix gripper recovery loop #17241

Merged
merged 1 commit into from
Jan 10, 2025
+5 −5
Merged

fix(app): Fix gripper recovery loop #17241

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/src/organisms/ErrorRecoveryFlows/shared/GripperIsHoldingLabware.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ export function GripperIsHoldingLabware({
// after the user has extricated the labware from the gripper jaws.
void handleMotionRouting(true)
.then(() => homeExceptPlungers())
.finally(() => handleMotionRouting(false))
.then(() => {
switch (selectedRecoveryOption) {
case MANUAL_MOVE_AND_SKIP.ROUTE:
Expand All @@ -73,7 +74,6 @@ export function GripperIsHoldingLabware({
}
}
})
.finally(() => handleMotionRouting(false))
}

const primaryOnClick = (): void => {
Expand Down
8 changes: 4 additions & 4 deletions app/src/organisms/ErrorRecoveryFlows/shared/__tests__/GripperIsHoldingLabware.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,16 +96,16 @@ describe('GripperIsHoldingLabware', () => {
expect(mockHomeExceptPlungers).toHaveBeenCalled()
})

await waitFor(() => {
expect(mockHandleMotionRouting).toHaveBeenCalledWith(false)
})

await waitFor(() => {
expect(mockProceedToRouteAndStep).toHaveBeenCalledWith(
RECOVERY_MAP.MANUAL_MOVE_AND_SKIP.ROUTE,
RECOVERY_MAP.MANUAL_MOVE_AND_SKIP.STEPS.MANUAL_MOVE
)
})

await waitFor(() => {
expect(mockHandleMotionRouting).toHaveBeenCalledWith(false)
})
})

it(`proceeds to the correct step when the no option is clicked for ${RECOVERY_MAP.MANUAL_REPLACE_AND_RETRY.ROUTE}`, async () => {
Expand Down
Loading