-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce abstraction for validated elements #191
Conversation
PR introduces changes to the public APIPlease add "ABI breaking" label if any line in API file was changed or deleted. Generated by 🚫 Danger Kotlin against 0646c19 |
Looks like there might be 10-15% overhead introduced by this change |
…set for enum assertion
Don't see any possibility to use Kaml in the nearest future. Better to use operation with less cost first This reverts commit f3339d8.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'KMP JSON schema validator'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.50
.
Benchmark suite | Current: fc624b7 | Previous: 66d118a | Ratio |
---|---|---|---|
macosX64.CommonAvgTimeBench.validateFlag ( {"objectPath":"openapi.json","schemaPath":"openapi_schema.json"} ) |
3240.5333712990937 us/op |
1976.2628132113823 us/op |
1.64 |
macosX64.CommonAvgTimeBench.validateFlag ( {"objectPath":"openapi-invalid.json","schemaPath":"openapi_schema.json"} ) |
2.261971690549861 us/op |
1.41092880120124 us/op |
1.60 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @OptimumCode
Make validation abstracted from the
JsonElement
Related to #190
Resolves #193