Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs > Content > Tables > With icons or thumbnails : Fix column height when contains an icon #1357

Closed
3 of 5 tasks
isabellechanclou opened this issue Jul 5, 2022 · 0 comments · Fixed by #1674
Closed
3 of 5 tasks
Assignees
Labels

Comments

@isabellechanclou
Copy link
Member

isabellechanclou commented Jul 5, 2022

Prerequisites

Describe the issue

This issue comes from the work done in Issue #1201 List in all the doc the incompatibility with ODS in which all Boosted components (variants included) have been inspected in order to identify the ones that do not respect ODS specifications and therefore need an alert message saying "Do not use in ODS".
Doing this work, design bugs were noticed.

Design bug to be corrected:

  • docs/v5.2/content/tables/with-icons-or-thumbnails:
    • Lines with icons shall have a 40 px height when lines with thumbnails shall have a 50 px height. At the moment, both contents (icons and thumbnails) are in the same table, with a unique line height of 50px.
      To fix that:
      1- Split the existing table into 2 different ones :
      a- one containing only icons
      b- and the other one containing only thumbnails.

      2- Check that the line height will auto adjust depending on its content and then have the expected height. Otherwise, change the way it's coded.
      Such modifications are OK for they impact Boosted only content.

    • The checkbox icon container shall be 40px x 40px instead of the present (30px x 30px + margin of 5px). See ODS specification "standard table with column header WEB-TBL-STD-003.
      image
      => See ODS specifications at https://system.design.orange.com/0c1af118d/p/21b04a-data-tables/b/56a1a9/i/66611045
      image

Reduced test cases

NA

What operating system(s) are you seeing the problem on?

macOS

What browser(s) are you seeing the problem on?

Chrome

What version of Boosted are you using?

v5.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants