-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move table-responsive class from <table> tag to <div> tag above #1710
Conversation
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Yes, your're right, so... Either we have a problem in the documentation (saying that |
There is a specific rule somewhere for the docs that can maybe cause this issue only in the docs:
You can try your modification outside of the docs context. Maybe that's just the extra-css for the docs that is the issue. |
If you want to cheat a little bit, you could probably use a |
It seems that this rule:
changes almost all tables over documentation, except the ones in Content>Tables section, because they are all wrapped inside Example from Back To Top > Sass options: Isn't it strange that all our tables across documentation do not respect our design specifications ? Why should we keep this strange rule ? |
Since Boosted doc must respect our design guidelines as well. From what I understand, we can probably remove this rule entirely by "Boosted mod"ing it and have a slightly different display compared to Bootstrap. |
The issue comes from the fact that the direct |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Related issues
Linked to issue #1357 and PR #1674
Description
.table-responsive
class was misused on some examples: it was positioned on the<table>
tag, whereas the documentation says to wrap the table inside a HTML tag (<div>
) with.table-responsive
.Motivation & Context
I saw this misuse while correcting some tables row height, on rich content tables examples.
Types of change
Live previews
Checklist
npm run lint
)