Add new info callout for ODS recommendation #1709
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
hannahiss
changed the title
|
I suppose this will be merged after the callouts PR. Just a comment for future selves: this PR will need an update of https://deploy-preview-1614--boosted.netlify.app/docs/5.2/getting-started/introduction/#about-orange-brand because it won't be anymore only "red"/"danger" messages/callouts. |
# Conflicts: # site/content/docs/5.2/content/tables.md
…patibility and recommandation)
There was a problem hiding this comment.
As a general comment, IMO the About Orange Brand section should also mention this new way of displaying recommendations. What do you think?
(see #1709 (comment))
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
…nto main-his-tables-reco-callouts
- removing unneeded boosted mod comments - adding info about blue design callout in introduction and update text about red ones - removing h4 class to callout title Also: - renaming ods-alert shortcode to design-callout-alert to be easier to find and refer
|
Kudos, SonarCloud Quality Gate passed!
|
Related issues
Linked to issue #1357 and PR #1674
Description
Add a new blue callout of level "info" to inform user that recommended tables are the small ones, with class
.table-sm(and not the "default" one).This PR stays in draft as long as the PR #1614 about design callouts is not merged. After that, and if we still want to add recommendation callout, we'll have to think about implementing all kinds of alerts (success and warning too) in a single piece of code.
Motivation & Context
This new callout has been discussed in web weekly spec review. Standard tables in DSM correspond to small tables in Boosted, and it wasn't mentioned anywhere. This callout could be used to make it clear to user, in addition to a renaming of tables in DSM.
Types of change
Live previews
Checklist
npm run lint)