-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore merge from 4b12084 #1842
Chore merge from 4b12084 #1842
Conversation
29897ce
to
fe991df
Compare
be67ae1
to
e02a0c9
Compare
8c8f14d
to
b86eb04
Compare
2309319
to
92d53e5
Compare
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few small things but looks already good to me
<button class="accordion-button" type="button" data-bs-toggle="collapse" data-bs-target="#collapseOne" aria-expanded="true" aria-controls="collapseOne"> | ||
Accordion Item #1 | ||
</button> | ||
</h2> | ||
<div id="collapseOne" class="accordion-collapse collapse show" aria-labelledby="headingOne" data-bs-parent="#accordionExample"> | ||
<div id="collapseOne" class="accordion-collapse collapse show" data-bs-parent="#accordionExample"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a reminder for me, should be backported to side-navigation as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feels great !
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
js/test/unit/collapse.spec.js
should probably be updated (see Tests: remove unnecessaryid
/aria-labelledby
from collapse unit tests twbs/bootstrap#38089)site/layouts/partials/footer.html
andsite/layouts/shortcodes/orange-footer.html
twbs/bootstrap@0d64dc6: nothing to do because these modifications come from Boosted--base00
and--base01
in light mode for Boosted based on our previous work on it to avoid any regressions