Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore merge from 4b12084 #1842

Merged
merged 18 commits into from
Feb 22, 2023
Merged

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented Feb 20, 2023

@julien-deramond julien-deramond added v5 merge Sync with Bootstrap skip:ci labels Feb 20, 2023
@julien-deramond julien-deramond force-pushed the main-jd-chore-merge-9e17b2b34cdec9dce063bba09b01aa9a63e7dd94 branch from be67ae1 to e02a0c9 Compare February 20, 2023 14:33
Base automatically changed from main-jd-chore-merge-9e17b2b34cdec9dce063bba09b01aa9a63e7dd94 to main February 21, 2023 07:59
@netlify
Copy link

netlify bot commented Feb 21, 2023

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit 5b61d7a
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/63f5d334fe376b000884deb9
😎 Deploy Preview https://deploy-preview-1842--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@julien-deramond julien-deramond marked this pull request as ready for review February 21, 2023 09:29
@julien-deramond julien-deramond mentioned this pull request Feb 21, 2023
7 tasks
Copy link
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few small things but looks already good to me

<button class="accordion-button" type="button" data-bs-toggle="collapse" data-bs-target="#collapseOne" aria-expanded="true" aria-controls="collapseOne">
Accordion Item #1
</button>
</h2>
<div id="collapseOne" class="accordion-collapse collapse show" aria-labelledby="headingOne" data-bs-parent="#accordionExample">
<div id="collapseOne" class="accordion-collapse collapse show" data-bs-parent="#accordionExample">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a reminder for me, should be backported to side-navigation as well.

site/content/docs/5.3/migration.md Show resolved Hide resolved
site/assets/js/snippets.js Show resolved Hide resolved
site/content/docs/5.3/components/toasts.md Outdated Show resolved Hide resolved
site/assets/scss/_syntax.scss Outdated Show resolved Hide resolved
site/content/docs/5.3/examples/form/index.html Outdated Show resolved Hide resolved
Copy link
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels great !

@sonarcloud
Copy link

sonarcloud bot commented Feb 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@julien-deramond julien-deramond merged commit 070147c into main Feb 22, 2023
@julien-deramond julien-deramond deleted the main-jd-chore-merge-from-4b12084 branch February 22, 2023 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge Sync with Bootstrap v5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants