Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore merge from da1c968 #1843

Merged
merged 7 commits into from
Feb 22, 2023
Merged

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented Feb 21, 2023

Warning
Must be merged after #1842

Stopped just before twbs/bootstrap@d70b5db which I'll do in a dedicated PR.

@julien-deramond julien-deramond changed the base branch from main to main-jd-chore-merge-from-4b12084 February 21, 2023 09:38
@julien-deramond julien-deramond added v5 merge Sync with Bootstrap skip:ci labels Feb 21, 2023
@netlify
Copy link

netlify bot commented Feb 21, 2023

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit dbcfafb
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/63f5db037d03dd0008872768
😎 Deploy Preview https://deploy-preview-1843--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@julien-deramond julien-deramond marked this pull request as ready for review February 21, 2023 11:58
@julien-deramond julien-deramond changed the title Main jd chore merge from da1c968 Chore merge from da1c968 Feb 21, 2023
Copy link
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will be funny until the white title fix 😄
[Out of PR] Do we need to reintroduce .accordion-flush, .floating-label, etc ?

However, nothing to mention apart great job !

@julien-deramond
Copy link
Member Author

[Out of PR] Do we need to reintroduce .accordion-flush, .floating-label, etc?

Based on what we're doing in Boosted, I'd say yes. Can you track it within an issue and we'll see what we can do about it in the next sprints.

Base automatically changed from main-jd-chore-merge-from-4b12084 to main February 22, 2023 09:04
@sonarcloud
Copy link

sonarcloud bot commented Feb 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@julien-deramond julien-deramond merged commit 5a1ef03 into main Feb 22, 2023
@julien-deramond julien-deramond deleted the main-jd-chore-merge-from-da1c968 branch February 22, 2023 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge Sync with Bootstrap v5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants