Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore merge from 17f14ac #1862

Merged
merged 11 commits into from
Mar 6, 2023
Merged

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented Feb 28, 2023

@julien-deramond julien-deramond added v5 merge Sync with Bootstrap labels Feb 28, 2023
@netlify
Copy link

netlify bot commented Feb 28, 2023

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit 26c4d00
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/64059860b4ea5c0008b7690b
😎 Deploy Preview https://deploy-preview-1862--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@julien-deramond julien-deramond marked this pull request as ready for review March 2, 2023 08:22
@sonarcloud
Copy link

sonarcloud bot commented Mar 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@julien-deramond julien-deramond mentioned this pull request Mar 6, 2023
20 tasks
Copy link
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering if we should change the grid example background color as well, but the remaining looks good to me !

@julien-deramond
Copy link
Member Author

Wondering if we should change the grid example background color

Yep wondering the same thing. We'll see when we implement the dark mode correctly since we will need to go through every pages in the docs to check everything.

@julien-deramond julien-deramond merged commit 1278c55 into main Mar 6, 2023
@julien-deramond julien-deramond deleted the main-jd-chore-merge-from-17f14ac branch March 6, 2023 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge Sync with Bootstrap v5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants