Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try web-ext #108

Merged
merged 4 commits into from
Feb 28, 2023
Merged

Try web-ext #108

merged 4 commits into from
Feb 28, 2023

Conversation

ffoodd
Copy link
Collaborator

@ffoodd ffoodd commented Feb 22, 2023

Trying to use web-ext to handle lint, build, and packaging.

Currently struggling with manifest.json handling since web-ext doesn't handle a custom manifest file specification for its commands.

@ffoodd ffoodd added enhancement dependencies Pull requests that update a dependency file labels Feb 22, 2023
@ffoodd ffoodd self-assigned this Feb 22, 2023
@ffoodd ffoodd marked this pull request as draft February 22, 2023 15:54
@ffoodd ffoodd mentioned this pull request Feb 22, 2023
2 tasks
@ffoodd
Copy link
Collaborator Author

ffoodd commented Feb 28, 2023

Worked around the manifest.json issue by copying the right one before each build / run tasks. A bit clunky but works.

web-ext run tasks work, however the Firefox one is buggy on Ubuntu because it's installed via snap. As a workaround, I'm thinking about using DevED instead of stable release, which could be installed without snap on Ubuntu and should be available at Orange.

FWIW ESR is not available without specifying its path, making this option useless for cross-env work.

@ffoodd ffoodd marked this pull request as ready for review February 28, 2023 14:33
@ffoodd
Copy link
Collaborator Author

ffoodd commented Feb 28, 2023

Keeping as-is for now: npm run load:firefox should be tested on Windows — and for Ubuntu users (like me), Firefox testing still needs to manually load extension through about:debugging.

To give some background:

  • using devEd (installed manually) doesn't work either,
  • we may launch web-ext through Node with env-paths to make cross-env paths to Firefox bin / cache, but that require a bit more work.

@ffoodd ffoodd merged commit d15262a into chore/manifest-v3 Feb 28, 2023
@ffoodd ffoodd deleted the chore/web-ext branch February 28, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant