Fixing async voids (Lombiq Technologies: OCORE-192) (#16441)

OrchardCMS · Jul 15, 2024 · 20f5aa4 · 20f5aa4
1 parent 29cd5fb
commit 20f5aa4
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/src/OrchardCore.Modules/OrchardCore.Email/Controllers/AdminController.cs b/src/OrchardCore.Modules/OrchardCore.Email/Controllers/AdminController.cs
@@ -61,7 +61,7 @@ public async Task<IActionResult> Test()
             Provider = _emailOptions.DefaultProviderName,
         };
 
-        PopulateModel(model);
+        await PopulateModelAsync(model);
 
         return View(model);
     }
@@ -107,7 +107,7 @@ public async Task<IActionResult> Test(EmailTestViewModel model)
             }
         }
 
-        PopulateModel(model);
+        await PopulateModelAsync(model);
 
         return View(model);
     }
@@ -140,7 +140,7 @@ private static MailMessage GetMessage(EmailTestViewModel testSettings)
         return message;
     }
 
-    private async void PopulateModel(EmailTestViewModel model)
+    private async Task PopulateModelAsync(EmailTestViewModel model)
     {
         var options = new List<SelectListItem>();
 

diff --git a/...ore/OrchardCore.Search.AzureAI.Core/Services/AzureAISearchDefaultOptionsConfigurations.cs b/...ore/OrchardCore.Search.AzureAI.Core/Services/AzureAISearchDefaultOptionsConfigurations.cs
@@ -26,7 +26,7 @@ public AzureAISearchDefaultOptionsConfigurations(
         _siteService = siteService;
     }
 
-    public async void Configure(AzureAISearchDefaultOptions options)
+    public void Configure(AzureAISearchDefaultOptions options)
     {
         var fileOptions = _shellConfiguration.GetSection("OrchardCore_AzureAISearch")
             .Get<AzureAISearchDefaultOptions>()
@@ -49,7 +49,9 @@ public async void Configure(AzureAISearchDefaultOptions options)
         else
         {
             // At this point, we can allow the user to update the settings from UI.
-            var settings = await _siteService.GetSettingsAsync<AzureAISearchDefaultSettings>();
+            var settings = _siteService.GetSettingsAsync<AzureAISearchDefaultSettings>()
+                .GetAwaiter()
+                .GetResult();
 
             if (settings.UseCustomConfiguration)
             {