Fixing async voids (Lombiq Technologies: OCORE-192) #16441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeAlhayek
approved these changes
Jul 15, 2024
|
There are analyzers for this that we can add under #7950. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
async voidis fire-and-forget, meaning that the code may or may not complete before the next line, making it unreliable. Exceptions thrown from such methods can also bring down the whole app. The only case where it's recommended for are event handles, see the official docs. So, fixing those here.I also searched for less trivial cases with
async (?!(Task|ValueTask|scope|override)\b)\w+but couldn't find any.