Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy preview docker image for Windows setp in the "Preview - CI" is failing #14703

Closed
MikeAlhayek opened this issue Nov 15, 2023 · 7 comments · Fixed by #14707
Closed

Deploy preview docker image for Windows setp in the "Preview - CI" is failing #14703

MikeAlhayek opened this issue Nov 15, 2023 · 7 comments · Fixed by #14707
Labels
Milestone

Comments

@MikeAlhayek
Copy link
Member

MikeAlhayek commented Nov 15, 2023

Strange error in the CI. It's failing. I am wondering if it is pulling from cache for some reason. The same step works on Ubuntu.

https://github.com/OrchardCMS/OrchardCore/actions/runs/6881515041/job/18718018240#step:13:230

 Sending build context to Docker daemon  580.4MB

Step 1/6 : FROM mcr.microsoft.com/dotnet/aspnet:8.0
8.0: Pulling from dotnet/aspnet
no matching manifest for windows/amd64 10.0.20348 in the manifest list entries
Login Succeeded
An image does not exist locally with the tag: ***/orchardcore-cms-windows
The push refers to repository [docker.io/***/orchardcore-cms-windows]
Error: Process completed with exit code 1.

@sebastienros @jtkech any idea why this step is failing?

@sebastienros sebastienros added this to the 1.x milestone Nov 16, 2023
@sebastienros
Copy link
Member

@sebastienros
Copy link
Member

Solution:

Detect the target os:
https://www.docker.com/blog/faster-multi-platform-builds-dockerfile-cross-compilation-guide/
https://devblogs.microsoft.com/dotnet/improving-multiplatform-container-support/

With 8.0-nanoserver-1809 on Windows (what 7.0 was pointing to before that change).

@MikeAlhayek
Copy link
Member Author

@sebastienros this is still failing after the fix was merged.

@MikeAlhayek MikeAlhayek reopened this Nov 21, 2023
@hishamco
Copy link
Member

I think the issue still exists

@MikeAlhayek
Copy link
Member Author

@hishamco yes that is what I said in my last comment and is why I re-opened the issue.

I'll research it more later on. I think we need to specify --platform parameter to the docker build command but not sure.

@sebastienros
Copy link
Member

I'll @jtkech close the issue if he thinks this is fixed

@jtkech
Copy link
Member

jtkech commented Dec 7, 2023

I may have some last tweaks to do but yes, it seems to work so I'm closing this issue.

@jtkech jtkech closed this as completed Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants