Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert Microsoft.SourceLink.GitHub update #14719

Closed
wants to merge 1 commit into from

Conversation

hishamco
Copy link
Member

@hishamco hishamco commented Nov 18, 2023

I just noticed that PR #14714 failed on Windows only for an unknown reason. Here is the actions list https://github.com/OrchardCMS/OrchardCore/actions/runs/6905925179

The merged PRs afterward are failing too. I'm not sure if the main reason is upgrading the package - which is weird - or the git workflow changes

/cc @MikeAlhayek @jtkech

@hishamco hishamco requested a review from agriffard as a code owner November 18, 2023 10:01
@hishamco
Copy link
Member Author

@hishamco
Copy link
Member Author

Related to #14703

@MikeAlhayek
Copy link
Member

MikeAlhayek commented Nov 18, 2023

@hishamco
You don't need to revert this. It was failing even before your update. I have a PR to fix the docker image for windows

#14707

@hishamco hishamco closed this Nov 18, 2023
@hishamco hishamco deleted the hishamco/github-source-link branch November 18, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants