Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.0.3 #16986

Closed
hishamco opened this issue Nov 10, 2024 · 6 comments
Closed

Release 2.0.3 #16986

hishamco opened this issue Nov 10, 2024 · 6 comments
Labels

Comments

@hishamco
Copy link
Member

The SMS Azure Module is missing in 2.0.1 and 2.0.2 which were merged on Sept 26

SMS Azure was introduced in #15539 and merged on Sept 16, this patch release adds the missing support. FYI I verified that the feature is missing with two clients

@hishamco
Copy link
Member Author

@sebastienros @MikeAlhayek please the patch release steps if there's no objection

@MikeAlhayek
Copy link
Member

@hishamco
Why isn't it included in 2.0? If it is not in 2.0.2, why would it be in 2.0.3? I suggest opening an issue, address the problem and then we can talk about a patch.

@hishamco
Copy link
Member Author

That's why I opened this issue

Why isn't it included in 2.0? If it is not in 2.0.2, why would it be in 2.0.3?

AFAIK the SMS Azure shipped after 2.0.0, then you shipped 2.0.1 and Seb reverted some changes in 2.0.2 I think the commit was not included accidentally

Try to check in 2.0.2 NuGet Packages

@MikeAlhayek
Copy link
Member

This issue is a request to release a new patch. You should have another issue explaining the problem so we can first fix it, then we can use this PR to ship the patch.

@hishamco
Copy link
Member Author

Done!!

#16988

@MikeAlhayek
Copy link
Member

I don't think this is needed "at least not at this time".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants