Support Azure Communication SMS

[hishamco]

Adds support for Azure Communication SMS

[MikeAlhayek]

Way too many files changes here. It seems that you copied all the SMS files into a new module. All you should need to do

1. Create OC.Sms.Azure module project
2. Implement the ISmsProvider and register it as described here https://docs.orchardcore.net/en/latest/docs/reference/modules/Sms/
3. You may want to add a provider for configuration provider using DefaultAzure key and another for Settings Azure. This way user can use a saas environment provider "if available" or they can enable one by providing their custom Azure instance settings like we did in the SMTP and Azure Email providers.

[hishamco]

As I said it's WIP, I'm working on it :)

[github-actions]

This pull request has merge conflicts. Please resolve those before requesting a review.

[github-actions]

It seems that this pull request didn't really move for quite a while. Is this something you'd like to revisit any time soon or should we close? Please comment if you'd like to pick it up.

[github-actions]

Closing this pull request because it has been stale for very long. If you think this is still relevant, feel free to reopen it.

[MikeAlhayek]

for instructions on how to resolve the merge conflicts due to #16572 please follow the step listed in this comment.

[hishamco]

@MikeAlhayek could you please do a quick review

[hishamco]

I suggest moving the Twilio-related types into OrchardCore.Sms.Twilio to follow the structure that we have before

[MikeAlhayek]

@hishamco here are some feedback. Also, please remove the template file changes from this PR.

Twilio provider should be kept in the Sms module.

[hishamco]

Related to https://github.com/OrchardCoreContrib/OrchardCoreContrib.Modules/tree/main/src/OrchardCoreContrib.Sms.Azure

[MikeAlhayek]

@hishamco now you created naming inconsistency between UI and documentation. Please use "Azure Communication SMS" everywhere as the suggestions below. This will keep naming consistency, and allow us to add another SMS provider offered by Azure later when they decide to introduce a new service.

The PR changed since the approval

[MikeAlhayek]

@hishamco
Can you please search for the docs and the code for anything that say Azure Communication SMS and replace it with *Azure Communication. Because when we are in the SMS UI, the term SMS is implied. So we should not repeat it everywhere specially in the UI.

[hishamco]

Can you please search for the docs and the code for anything that say Azure Communication SMS and replace it with *Azure Communication.

Nothing except this docs

[hishamco]

If it's ok I will merge then

[MikeAlhayek]

I thought you did the string/replace.

[hishamco]

I looked for what you asking for "Azure Communication SMS" not "Azure SMS" :)

[MikeAlhayek]

/backport to release/2.0

[github-actions]

Started backporting to release/2.0: https://github.com/OrchardCMS/OrchardCore/actions/runs/11782162720

[hishamco]

The first time I saw such BOT when it was introduced.