Admin UI : header buttons

[Skrypt]

Before #7851 :

After #7851 :

I found out that we are displaying these buttons inside a hamburger menu now.
I'm not a fan of it. They should be displayed all the time.
If we have other menu items then they should be added in the hamburger menu but only if they have a text.
This looks strange needing to open the hamburger menu to toggle the darkmode.

/cc @agriffard

[hishamco]

Seems the icons are wiered in the humberger menu, could we use text instead

[Skrypt]

No it needs to be removed from that hamburger menu. Make it how it was before.

[hishamco]

May be the first screenshot is accepted but the other once introduce a spacing issue which is not needed

[Skrypt]

Well the hamburger menu is not necessary at all I think. We should keep it if people want to extend the top menu with their own menu items (text links). Else I don't think we need it.

[agriffard]

What about only show text on small?:

[Skrypt]

I'm sorry but I have to say that I don't like it. It doesn't look right.
One of the reasons is that the user menu should not open a second modal like this inside the hamburger menu.
Also, the darkmode and frontend website buttons should be accessible directly in the top bar like the notification button is for Github. Also, notice that the page title is never appended in the top navbar either.

Maybe you will say that I'm picky but I can't help but noticing these small details...

[Skrypt]

Frontend hamburger menu :

Backend hamburger menu :

I think we should follow the second example.

[hishamco]

That's why I vote for the text in the menu items at the beginning ;)

[sebastienros]

We can't have this hamburger menu in mobile view. This is a regression, and we closed a similar PR some time ago for the same reason. Sorry I didn't think about asking about the mobile view during the meeting. We need more time to evaluate all the changes before taking it.

Better create multiple PRs too for instance for the content items list so we can give feedback independently, and not merge all or nothing.