-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Admin link #7851
Admin link #7851
Conversation
Fixes #7806
Include $('[data-toggle="tooltip"]').tooltip(); in TheAdmin.js
I like the changes based on the screenshot, hope @Skrypt like it too |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, UserMenu moved to navbar-collapse => margin removed. |
Co-authored-by: Jasmin Savard <jasmin.savard@gmail.com>
Co-authored-by: Jasmin Savard <jasmin.savard@gmail.com>
src/OrchardCore.Modules/OrchardCore.Users/Views/UserMenu.cshtml
Outdated
Show resolved
Hide resolved
src/OrchardCore.Modules/OrchardCore.Users/Views/UserMenu.cshtml
Outdated
Show resolved
Hide resolved
Co-authored-by: Jasmin Savard <jasmin.savard@gmail.com>
Co-authored-by: Jasmin Savard <jasmin.savard@gmail.com>
The only thing "buggy" is the tooltip on the dark/light mode button. We would need to be able to create translations for javascript. |
Why does it seems buggy according to you? |
When I click on it ; the Tooltip title doesn't toggle from dark to light, vice versa. Now you assign the tooltip from server side depending on the actual mode it is but it can be changed on client side ... And the tooltip text should be changed in darkmode.js file of TheAdmin theme by changing the anchor title attribute. I think you changed this because previously it was using data-title-something. |
Fixes #7806
Separate the upper left infos of the admin in two links: