Workflows #1378
Workflows #1378
Conversation
# Conflicts: # Orchard.sln # src/OrchardCore.Modules/Orchard.Demo/Middlewares/BlockingMiddleware.cs # src/OrchardCore.Modules/Orchard.Demo/Views/Home/Index.cshtml # src/OrchardCore.Modules/Orchard.Mvc/Startup.cs # src/OrchardCore.Modules/Orchard.Resources/ResourceManifest.cs # src/OrchardCore.Modules/Orchard.Setup/Recipes/cms.recipe.json # src/OrchardCore.Modules/Orchard.Widgets/Controllers/AdminController.cs # src/OrchardCore/Orchard.DisplayManagement/Notify/NotifyFilter.cs # src/OrchardCore/Orchard.Mvc.Core/Extensions/ModularServiceCollectionExtensions.cs # src/OrchardCore/Orchard.ResourceManagement/ResourceManager.cs # src/OrchardCore/OrchardCore.Cms/OrchardCore.Cms.csproj
# Conflicts: # OrchardCore.sln # src/OrchardCore.Modules/OrchardCore.OpenId/Drivers/OpenIdServerSettingsDisplayDriver.cs
| IClock clock, | ||
| IStringLocalizer<SecurityTokenService> localizer) | ||
| { | ||
| _dataProtector = dataProtectionProvider.CreateProtector("Tokens").ToTimeLimitedDataProtector(); |
There was a problem hiding this comment.
Note: now that you merged the dev branch into your branch, you'll probably want to add a module dependency on OrchardCore.DataProtection to ensure the IDataProtectionProvider instance you get is tenant-isolated (and not provided by the host).
There was a problem hiding this comment.
I'm not sure I understand. If Workflows should use the tenant-isolated service, then shouldn't all modules using data protection use the tenant-isolated one?
There was a problem hiding this comment.
I assume you get an instance from an indirect reference to a module that requires it, but you require it too and you should declare a dependency on it.
There was a problem hiding this comment.
I see now. Thanks, will fix.
Yes i tried it and it triggers every 1 minute. So, if your 1st reference time is 2min:01sec it will trigger at 3min:00 and then at 4min:00 and so on. But if your 1st reference time is e.g 2min:59sec, the first occurence is still 3min:00 (only one second after). |
|
Ah now I see what you mean. That does behave differently than what one might expect when using a Timer activity. So perhaps I should rename it to Cron, and reintroduce a Timer activity that does more or less exactly what one might expect: trigger every X interval from the point where the service started. One concern though is that the difference between the two might be too subtle. What do you think about this? |
|
Hmm, just an idea, what you could do is to get the next occurence, reinit your reference to this occurence and get again the next occurence, so that you can compute the time span between 2 occurences. Then you will have to wait from now to now + this time span. Maybe we could have an option to use the cron expression as a time interval.
Note: knowing that right now the granularity of bg tasks is 1 minute. But not sure it is clearer ;) just an idea. |
|
That's very clever, I like it! |
|
Added a card for it here: https://github.com/OrchardCMS/OrchardCore/projects/4#card-9037009 |
|
I wanted to merge it, then the merge is conflicting (with theme changes) Someone fixes it and merge please. |
|
I'll fix. |
# Conflicts: # src/OrchardCore.Themes/TheAdmin/Assets/scss/TheAdmin.scss # src/OrchardCore.Themes/TheAdmin/wwwroot/Styles/TheAdmin.css
|
|
This PR adds the new Workflows module.