Various Workflows tweaks and bug-fixes #1700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
sfmskywalker
commented
Apr 22, 2018
sfmskywalker
commented
- Fixing a bug that causes a stack overflow when workflows have repeating paths.
- Fixing a bug in CreateContent activity editor (Publish setting would not be saved).
- Fixing a bug in CreateContent activity (JSON to be processed with Liquid, not JavaScript).
- Fixing a bug in EmailTask returning the wrong outcome.
- Fixing an issue where the same activity can be added multiple times to the workflow's blocking activities collection.
- Fixing an issue with resuming a workflow that is blocked on multiple Signal activities. Only the first activity would be selected and tried, instead of all matching blocking activities.
- Adding LastResult property to Liquid Template Context.
- Adding HTTP POST support for workflow URLs. This enables HTTP clients to actually POST content to a workflow, e.g. to submit content for review.
- Setting LastResult to "TimerEvent" when a timer has ticked to simplify joining a forked execution path and making a decision of where to go next.
- Fixing a typo in an activity's description.
* Fixing a bug that causes a stack overflow when workflows have repeating paths. * Fixing a bug in CreateContent activity editor (Publish setting would not be saved). * Fixing a bug in CreateContent activity (JSON to be processed with Liquid, not JavaScript). * Fixing a bug in EmailTask returning the wrong outcome. * Fixing an issue where the same activity can be added multiple times to the workflow's blocking activities collection. * Fixing an issue with resuming a workflow that is blocked on multiple Signal activities. Only the first activity would be selected and tried, instead of all matching blocking activities. * Adding LastResult property to Liquid Template Context. * Adding HTTP POST support for workflow URLs. This enables HTTP clients to actually POST content to a workflow, e.g. to submit content for review. * Setting LastResult to "TimerEvent" when a timer has ticked to simplify joining a forked execution path and making a decision of where to go next. * Fixing a typo in an activity's description.
sfmskywalker
changed the title
|
You may also want to fix that: #1378 (comment) 😅 |
|
Ah yes, I’ll check that out. Thanks! |
|
conflicts |
added 2 commits
April 24, 2018 22:18
# Conflicts: # src/OrchardCore.Modules/OrchardCore.Workflows/Http/Controllers/HttpWorkflowController.cs # src/OrchardCore.Modules/OrchardCore.Workflows/Services/WorkflowManager.cs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.