-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update methods #16452
Update methods #16452
Conversation
Thank you for submitting your first pull request, awesome! 🚀 If you haven't already, please take a moment to review our contribution guide. This guide provides helpful information to ensure your contribution aligns with our standards. A core team member will review your pull request. |
I already wrote my personal opinion on these PRs that you have opened, at least on the repositories I am involved: dotnet/aspire#4747 (comment) |
Agree with Sebastien. Currently, we do such formatting changes/decisions case-by-case, according to the personal preference of the author. This is not a good approach, and rather we should make decisions for each style yes or no, have the debate closed, and introduce code analysis (#7950) to enforce the selected one. Right now, this doesn't really bring much benefit but introduces friction by creating a conflict for each PR (and we'll still introduce new discrepancies until analyzers are employed). I'm personally for expression-bodied members, but this doesn't matter here. Until then, while I thank you @KhanbalaRashidov for your contribution, I don't think we should apply rules for the whole codebase. And please do consider contributing to Orchard Core again; however, keep the above-linked contribution guide in mind, including:
|
Thanks @Piedone |
No description provided.