Check for Line elements in parseSVG paths #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was wondering if it makes sense to cut a line into 'steps_per_seg' subsegments. This significantly reduces the number of G-Code commands sent to the robot. I came across this as I am working on my Inkscape plugin. But I still have some distance to go. If you are interested: https://github.com/fdraeger/uArmSwiftPro_InkscapePlugin Keep up the good work!
|
Looks good, thanks! The InkScape-plugin sounds awesome! Cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was wondering if it makes sense to cut a Line into 'steps_per_seg' subsegments.
So I am checking for Line objects in the path and create two coordinate points.
This change significantly reduces the number of G-Code commands sent to the robot.
I came across this as I am working on my Inkscape plugin. But I still have some distance to go.
If you are interested: https://github.com/fdraeger/uArmSwiftPro_InkscapePlugin
Keep up the good work!