-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Frequency analysis misleadingly characterized as resampling indicator #1263
Comments
aulemahal
added a commit
that referenced
this issue
Aug 31, 2023
<!--Please ensure the PR fulfills the following requirements! --> <!-- If this is your first PR, make sure to add your details to the AUTHORS.rst! --> ### Pull Request Checklist: - [x] This PR addresses an already opened issue (for bug fixes / features) - This PR fixes #1263 - [ ] Tests for the changes have been added (for bug fixes / features) - [x] (If applicable) Documentation has been added / updated (for bug fixes / features) - [x] CHANGES.rst has been updated (with summary of main changes) - [x] Link to issue (:issue:`number`) and pull request (:pull:`number`) has been added ### What kind of change does this PR introduce? Move around some of the base indicator classes code. Split the missing values handling from the resampling handling. This way, indicators like `return_level` can reduce the full time axis and still perform some missing values handling. ### Does this PR introduce a breaking change? No, not yet. ### Other information: @huard @RondeauG, if I am not mistaken, `return_level` and `fit` currently have missing values handling disabled because it was impossible with the previous classes to have both this and full reduction of "time". Now that it is possible, should we activate it ? Similarly, `stats` had the "Any" missing method forced. Is there a reason for that ? Here, I removed the argument, meaning it will use "from_context".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
xclim/xclim/indicators/land/_streamflow.py
Line 73 in c8f45a7
where
FA
is a subclass ofResamplingIndicator
. However, the index reduces thetime
axis completely, which is not what we would expect from aResamplingIndicator
that exposes afreq
argument.Maybe we should have a new subclass for this type of indicator and rename the
freq
argument to make it less misleading.The text was updated successfully, but these errors were encountered: