Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist:
number
) and pull request (:pull:number
) has been addedWhat kind of change does this PR introduce?
Move around some of the base indicator classes code. Split the missing values handling from the resampling handling. This way, indicators like
return_level
can reduce the full time axis and still perform some missing values handling.Does this PR introduce a breaking change?
No, not yet.
Other information:
@huard @RondeauG, if I am not mistaken,
return_level
andfit
currently have missing values handling disabled because it was impossible with the previous classes to have both this and full reduction of "time". Now that it is possible, should we activate it ?Similarly,
stats
had the "Any" missing method forced. Is there a reason for that ? Here, I removed the argument, meaning it will use "from_context".