-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PyOpenSci] Documentation and Notebook Adjustments, manage SBCK #1338
Conversation
…ed to install SBCK, install SBCK via pip in upstream build
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
for more information, see https://pre-commit.ci
I removed seaborn. As I understand it, the point of this section is to show that the labels are integrated automatically on the plot from the attributes created by xclim. I thought this was illustrated well enough by matplotlib. I didn't see the added value of having seaborn also. |
Re: |
@juliettelavoie I was getting odd messages if |
Pull Request Checklist:
number
) and pull request (:pull:number
) has been addedWhat kind of change does this PR introduce?
correctedreduced.SBCK
has been pulled fromenvironment.yml
for the time being until a proper package is created.Does this PR introduce a breaking change?
Yes, but no1. Changes to dependencies have been handled in such a way that default settings are unaffected. Development and CI-based behaviour is affected:
clisops
andflox
are now in theenvironment.yml
.Other information:
yrobink/SBCK-python#5
Footnotes
https://i.kym-cdn.com/entries/icons/original/000/028/596/dsmGaKWMeHXe9QuJtq_ys30PNfTGnMsRuHuo_MUzGCg.jpg ↩