Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyPI Package? #5

Closed
Zeitsperre opened this issue Mar 22, 2023 · 2 comments
Closed

PyPI Package? #5

Zeitsperre opened this issue Mar 22, 2023 · 2 comments

Comments

@Zeitsperre
Copy link
Contributor

Hi @yrobink,

I'm wondering if you would be interested in having SBCK-python as a pip-installable Python package on PyPI. My PR (#4) fixes most of the issues that would block this package from being contributed, and the remaining work involved is miniscule (creating a user, generating a source package, uploading to PyPI with twine).

If this is of interest to you, I don't mind contributing some time towards this. This would be a welcome addition for xclim.

@yrobink
Copy link
Owner

yrobink commented Mar 27, 2023

Dear @Zeitsperre,

Thanks for your contribution, your PR is now merged.

I had planned to make SBCK installable by pip and conda once the XSBCK (https://github.com/yrobink/XSBCK) development was advanced enough. I'll try to take care of it earlier.

Zeitsperre added a commit to Ouranosinc/xclim that referenced this issue Mar 31, 2023
### What kind of change does this PR introduce?

* Grammar and spelling mistakes within the notebooks have been
~corrected~ reduced.
* `SBCK` has been pulled from `environment.yml` for the time being until
a proper package is created.
* The Contributing guide now lists three separate subsections to help
users understand the gains from optional dependencies

### Does this PR introduce a breaking change?

Yes, but no[^1]. Changes to dependencies have been handled in such a way
that default settings are unaffected. Development and CI-based behaviour
is affected: `clisops` and `flox` are now in the `environment.yml`.

### Other information:
yrobink/SBCK-python#5
[^1]:
https://i.kym-cdn.com/entries/icons/original/000/028/596/dsmGaKWMeHXe9QuJtq_ys30PNfTGnMsRuHuo_MUzGCg.jpg
@yrobink
Copy link
Owner

yrobink commented May 3, 2023

Dear @Zeitsperre ,

SBCK is now available in pypi:

https://pypi.org/project/SBCK/

@yrobink yrobink closed this as completed May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants