Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust expected dependencies and more accurate license classifers #4

Merged
merged 3 commits into from
Mar 27, 2023

Conversation

Zeitsperre
Copy link
Contributor

Fixes #2

Changes

  • In lieu of using requires (from distutils), package dependencies use install_requires (from setuptools) to specify install-time dependencies.
  • License string for GPLv3 License now conforms to Python metadata expectations.
  • Other relevant metadata classifiers are now listed in the package.

Justification

What was happening previously was that because requires was present, install_requires was ignored. As such, pybind11 was not being installed by default when installing via pip. requires does not allow for non-alphanumeric characters in dependency entries (i.e.: no setting of versions).

@Zeitsperre Zeitsperre mentioned this pull request Mar 22, 2023
@yrobink yrobink merged commit 43fdf43 into yrobink:master Mar 27, 2023
@yrobink
Copy link
Owner

yrobink commented Mar 27, 2023

Dear @Zeitsperre,

Thanks for your PR, it is now merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SBCK is missing pybind11 as an installation requirement
2 participants