Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.20.3 #880

Merged
merged 27 commits into from
Jun 4, 2024
Merged

1.20.3 #880

merged 27 commits into from
Jun 4, 2024

Conversation

JohnCorby
Copy link
Member

@JohnCorby JohnCorby commented Jun 3, 2024 •
edited by xen-42
Loading

Minor features

  • Added parentPath to scatter. This parent should be at the position where you'd like to scatter (which would usually be zero).

Improvements

Bug fixes

  • Prevents a softlock when at the eye (JohnCorby's fault) (Fix Stuck when loading into the Eye #865)
  • Pause on load like in base game (Fix Prevent drifting after entering system-changing black hole #783)
  • Fixed disabled reference frames not being disabled (for the third time)
  • Fixed sectors being rotated on tidally locked bodies
  • Fixed scatter not working properly on tidally locked bodies
  • Fixed returning to solar system radius not being calculated correctly
  • Supposedly fixed rafts but didn't actually (wtf Hawkbar!)
  • Stop popups spamming your entire save file potentially.

xen-42 and others added 19 commits May 19, 2024 14:36
@xen-42
Update NewHorizonsData.cs
566d840
@MegaPiggy
Popups read spam (#863)
6a63658 
## Bug fixes
- Fix save file bloat from reading popups
@JohnCorby
Fix wrong merge (#864)
3476388 
Accidently merged into wrong branch so uhh yeah
@MegaPiggy
Fix and update xsd schemas
8112995
@MegaPiggy
rearrange things
c9132a1 
to somewhat match base games's xmls even if they aren't always consistent there
@MegaPiggy
Fix and update xsd schemas (#866)
fb9e10f 
## Improvements

- Added ReuseDialogueOptionsListFrom, DisablePersistentCondition, and
ParentIgnoreNotRevealed to their respective schemas
- Specify (and also correct some) minOccurs & maxOccurs on EVERYTHING
(this one is for you visual studio)

- Rearranged things to better match the xmls from vanilla
@MegaPiggy
Add parentPath to scatter
3265f8b
@MegaPiggy
Fix sectors being rotated on tidally locked bodies
892bf62
@MegaPiggy
Make it local so that scatter works on tidally locked bodies
90f7d23
@MegaPiggy
Update schemas
5027ca8
@MegaPiggy
Fix the solar system radius calculation
14cf9ce 
needs to divide not multiply
@MegaPiggy
Move scatter after details
6a516ef 
So that we can parent it to a root detail
@MegaPiggy
Set reference frame collider radius to just above zero
4719831 
because it being at zero makes it use the sphereOfInfluence instead
@JohnCorby
MAYBE fix eye softlock (and use owml methods instead of copied qsb ones)
7489ecb
@JohnCorby
forgot to pass in the right arguments
1d41360
@JohnCorby
do things as properly as i can
8ec148b
@JohnCorby
format
79ad864
@MegaPiggy
check InConversation to avoid unnecessary EndConversation calls (#859)
fc1f25a 
even though this already happens in CharacterDialogueTree.EndConversation itself, I did it for Ixrec anyways.
@JohnCorby
Fix eye softlock maybe (#874)
2fe4267 
## Bug fixes

- fix #865: dont softlock when at the eye (johncorby's fault) 
- fix #783: pause on load like base game does
@JohnCorby JohnCorby added the update-pr Marks pull requests as an update PR label Jun 3, 2024
xen-42 added 8 commits June 3, 2024 22:46
@xen-42
Check InConversation to avoid unnecessary EndConversation calls (#877)
fef13f6 
## Improvements

- fix #859: CharacterDialogueTree.InConversation is now checked in our
attachment patch to avoid unnecessary EndConversation calls.
@xen-42
Fix disabled reference frames not being disabled AGAIN (#873)
5e237d5 
## Bug fixes

- Fix disabled reference frames not being disabled (I swear I've done
this 3 times now)
@xen-42
Add a comment
e74e690
@xen-42
Fix sectors being rotated on tidally locked bodies (#870)
803a6c2 
## Bug fixes

- Fixed sectors being rotated on tidally locked bodies
@xen-42
Add comment
e617d98
@xen-42
Scatter parenting and fixes for tidally locked bodies (#872)
fe896a5 
## Minor features

- Added `parentPath` to scatter. This parent should be at the position
where you'd like to scatter (which would usually be zero).

## Bug fixes

- Fix scatter not working properly on tidally locked bodies
@xen-42
Fix the solar system radius calculation (#869)
802d6e1 
## Bug fixes

- Fixed returning to solar system radius not being calculated correctly
@xen-42
Update manifest.json
0f56b59
@xen-42 xen-42 marked this pull request as ready for review June 4, 2024 03:51
xen-42
xen-42 approved these changes Jun 4, 2024
View reviewed changes
Copy link
Member

@xen-42 xen-42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@JohnCorby JohnCorby merged commit d87b2d0 into main Jun 4, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xen-42 xen-42 xen-42 approved these changes

Assignees
No one assigned
Labels
update-pr Marks pull requests as an update PR
Projects
None yet
Milestone
No milestone
3 participants
@JohnCorby @xen-42 @MegaPiggy