build: make the C99 requirement explicit #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recent code uses C99 syntax (as reported in PCRE2Project#163, and therefore it will fail to build unless C99 (or higher) support is required by the compiler (gcc >= 5 does it by default). For those unfortunate to need an older compiler that does require a flag to enable that, make sure that both autoconf and cmake make it explicit. While testing the change with the ancient autoconf version listed as a prerequisite, noticed that the LT_INIT syntax introduced with 91485e5 (Update configure.ac for latest version of autoconf., 2021-02-02), was not supported, so update the autoconf minimum as well.
3 tasks
bryce-cahill
pushed a commit
to bryce-cahill/conan-center-index
that referenced
this pull request
Sep 10, 2023
bryce-cahill
pushed a commit
to bryce-cahill/conan-center-index
that referenced
this pull request
Sep 10, 2023
bryce-cahill
pushed a commit
to bryce-cahill/conan-center-index
that referenced
this pull request
Sep 14, 2023
bryce-cahill
added a commit
to bryce-cahill/conan-center-index
that referenced
this pull request
Sep 25, 2023
conan-center-bot
pushed a commit
to conan-io/conan-center-index
that referenced
this pull request
Sep 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes to bootstrapping with older tools that would result in broken builds.
The
configure.acuses additional syntax to keep using the original macro that is used in bootstrapping for releases and that works fine even with really old gcc (would test and try to enable up to C11) and could be dropped once theAC_PREREQis updated as originally intended.